Skip to content

Remove Nimbus(Reactive)OpaqueTokenIntrospector #17326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove Nimbus(Reactive)OpaqueTokenIntrospector #17326

wants to merge 2 commits into from
+121 −1,302

Conversation

ngocnhan-tran1996
Copy link
Contributor

Closes gh-17302

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 21, 2025
@jzheaux jzheaux self-assigned this Jun 24, 2025
@jzheaux jzheaux added type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: breaks-passivity A change that breaks passivity with the previous release and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 24, 2025
@jzheaux jzheaux added this to the 7.0.x milestone Jun 24, 2025
jzheaux
jzheaux requested changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ngocnhan-tran1996 for the PR! I've left my feedback inline.

.../org/springframework/security/config/http/OAuth2ResourceServerBeanDefinitionParserTests.java
@@ -963,14 +965,29 @@ private void mockWebServer(String response) {
.setBody(response));
}

private void mockRestOperations(String response) {
private void mockJwksRestOperations(String response) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to place this change in a separate commit? In this way, the deprecation commit only contains the changes needed for deprecation to happen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your feedback. I've updated it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux requested changes

Assignees

@jzheaux jzheaux

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: breaks-passivity A change that breaks passivity with the previous release type: enhancement A general enhancement
Projects
None yet
Milestone
7.0.x
Development

Successfully merging this pull request may close these issues.

Remove Nimbus(Reactive)OpaqueTokenIntrospector
3 participants
@ngocnhan-tran1996 @jzheaux @spring-projects-issues